fix(qualys_vmdr): use join for ID_SET in KB response error path#17932
Open
andrewkroh wants to merge 1 commit intoelastic:mainfrom
Open
fix(qualys_vmdr): use join for ID_SET in KB response error path#17932andrewkroh wants to merge 1 commit intoelastic:mainfrom
andrewkroh wants to merge 1 commit intoelastic:mainfrom
Conversation
andrewkroh
force-pushed
the
fix/qualys_vmdr/no-such-overload-rate-limit-chain
branch
from
2ecb88e to
350ad89
Compare
andrewkroh
added
Integration:snyk
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
andrewkroh
changed the title
andrewkroh
force-pushed
the
fix/qualys_vmdr/no-such-overload-rate-limit-chain
branch
2 times, most recently
from
19d8105 to
2c40c2a
Compare
kortschak
reviewed
Mar 20, 2026
error path
The CEL expression at line 244 calls string() on the result
of ID_SET.orValue([]) which is a list. When the knowledge
base API response is missing expected ID values, this path
triggers string(list) which has no overload.
Replace string() with join(" ") to properly convert the list
to a string for the error message.
andrewkroh
force-pushed
the
fix/qualys_vmdr/no-such-overload-rate-limit-chain
branch
from
2c40c2a to
8305f52
Compare
andrewkroh
changed the title
andrewkroh
removed
Integration:snyk
💚 Build Succeeded
History
|
efd6
approved these changes
Mar 22, 2026
Contributor
efd6
left a comment
efd6
left a comment
There was a problem hiding this comment.
LGTM as an alter ego. You may want another approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.