fix(agent): topTalkersByBytes display names after v0.6.0#26
Merged
Conversation
## Added - Per-source terms sub-agg on srcDisplayNameField when field caps show it as aggregatable; rows gain topSrcDisplayNames (displayName + docCount). - Skips duplicate terms agg when display field matches pod name field. ## Changed - Tool spec and FLOW_ANALYTICS playbook text for the LLM.
- Skip top_display_names when display agg field matches namespace terms - Test non-aggregatable srcDisplayNameField (no agg, no topSrcDisplayNames) - Test display/namespace field collision - Tool spec note on dedupe Tool results remain unstructured (ToolResult.result: unknown); no Zod/OpenAPI surface for per-tool payloads.
## Changed - Skip display-name terms agg when it matches pod or namespace terms field. - Shorten topTalkersByBytes tool description. - Assert by_src sub-aggs via a small bySrcAggs helper; fix namespace collision test.
kgrubb
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to v0.6.0: that release laid out source display-name support for
topTalkersByBytes, but the OpenSearch request could still attach a redundanttermssub-aggregation when the display field matched the pod or namespaceterms field. This branch corrects that and locks the behavior in tests.
Fixed
top_display_namessub-agg whensrcDisplayNameFieldresolves tothe same field as the pod or namespace
termsaggs, so the query matches theintended shape and row data stays consistent.
by_srcsub-aggs via a small helper so collisions andnon-aggregatable display fields stay covered.
Changed
topTalkersByBytestool description; FLOW_ANALYTICS copy still nudgesthe model toward
topSrcDisplayNameswhen buckets exist.Notes
empty buckets mean no label in the underlying flow documents.