Updated to work with current webpack (4.x) and UglifyJS#5
Open
jrheling wants to merge 1 commit intoelboman:masterfrom
Open
Updated to work with current webpack (4.x) and UglifyJS#5jrheling wants to merge 1 commit intoelboman:masterfrom
jrheling wants to merge 1 commit intoelboman:masterfrom
Conversation
|
@jrheling I just stopped by to say thank you for this pull request, it saved me a lot of time. The fact this otherwise excellent article is outdated is hard to spot unless you look at a comment section (lack of publication dates alongside article titles doesn't help either) and it's particularly problematic because it still ranks high in Google search. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your example was really helpful as I worked through packaging a typescript component (thanks!), but I found a handful of details that no longer worked as illustrated in the example. I can't say with confidence that the attached is optimal, but it seems to produce the desired result, and I think is functionally equivalent to the original (but in a way that works with current versions of things).