Skip to content

Fixes issue of connection string errors not returned properly to the caller #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akalanka47000 merged 1 commit into from
Dec 14, 2025
Merged

Fixes issue of connection string errors not returned properly to the caller #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 15 additions & 8 deletions core/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,23 +59,30 @@ func Connect(arg any) mongo.Client {
}

opts.Alias = lo.CoalesceOrEmpty(opts.Alias, "default")

clientOpts := lo.CoalesceOrEmpty(opts.ClientOptions, options.Client()).
SetServerAPIOptions(options.ServerAPI(options.ServerAPIVersion1)).
SetPoolMonitor(lo.CoalesceOrEmpty(opts.PoolMonitor, defaultPoolMonitor(opts.Alias)))
if clientOpts.GetURI() == "" {
if opts.URI == "" {
panic(ErrURIRequired)
}
clientOpts = clientOpts.ApplyURI(opts.URI)
SetPoolMonitor(lo.CoalesceOrEmpty(opts.PoolMonitor, defaultPoolMonitor(opts.Alias))) // Set default client options if not provided

if opts.URI = lo.CoalesceOrEmpty(clientOpts.GetURI(), opts.URI); opts.URI == "" { // We prioritize the URI set in the client options if both are provided
panic(ErrURIRequired)
}
cs := lo.Must(connstring.ParseAndValidate(clientOpts.GetURI()))

lo.Must0(clientOpts.ApplyURI(opts.URI).Validate())

cs, _ := connstring.Parse(opts.URI) // We can ignore the error here since we already validated the URI above
defaultDatabases[opts.Alias] = cs.Database

ctx, cancel := context.WithTimeout(context.Background(), *lo.CoalesceOrEmpty(clientOpts.ConnectTimeout, lo.ToPtr(ConnectionTimeout)))
defer cancel()

client := lo.Must(mongo.Connect(ctx, clientOpts))
lo.Must0(client.Ping(ctx, readpref.Primary()))
lo.Must0(client.Ping(ctx, readpref.Primary())) // Verify connection

clients[opts.Alias] = client

triggerEventIfRegistered(opts.Alias, EventDeploymentDiscovered)

return *client
}

Expand Down