Fix partial download recovery and handle missing Files field in Sources#2
Open
dybai wants to merge 1 commit into
Open
Fix partial download recovery and handle missing Files field in Sources#2dybai wants to merge 1 commit into
dybai wants to merge 1 commit into
Conversation
This commit addresses two issues:
1. Fix partial download recovery:
- When network errors occur during download, some files in skel_path
may be smaller than expected. Previously, apt-mirror would not
re-download these incomplete files on subsequent runs, requiring
manual deletion. Now, the script automatically detects and removes
incomplete temporary files before checking if an update is needed.
2. Handle missing Files field in Sources index:
- Some source package index files don't contain a Files: field,
which caused "Use of uninitialized value" warnings. While these
warnings didn't affect synchronization, they were noisy. The code
now checks for the existence of the Files: field before processing
it, only handling entries that contain this field.
Changes:
- Add check_and_clean_partial_download() function to detect and remove
incomplete downloads in skel_path
- Call check_and_clean_partial_download() before need_update() for both
Packages and Sources processing
- Add existence check for Files: field in Sources index processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit addresses two issues:
Fix partial download recovery:
Handle missing Files field in Sources index:
Changes: