Skip to content

Fix partial download recovery and handle missing Files field in Sources#2

Open
dybai wants to merge 1 commit into
electricworry:masterfrom
dybai:check_and_clean_partial_download
Open

Fix partial download recovery and handle missing Files field in Sources#2
dybai wants to merge 1 commit into
electricworry:masterfrom
dybai:check_and_clean_partial_download

Conversation

@dybai

@dybai dybai commented Dec 16, 2025

Copy link
Copy Markdown

This commit addresses two issues:

  1. Fix partial download recovery:

    • When network errors occur during download, some files in skel_path may be smaller than expected. Previously, apt-mirror would not re-download these incomplete files on subsequent runs, requiring manual deletion. Now, the script automatically detects and removes incomplete temporary files before checking if an update is needed.
  2. Handle missing Files field in Sources index:

    • Some source package index files don't contain a Files: field, which caused "Use of uninitialized value" warnings. While these warnings didn't affect synchronization, they were noisy. The code now checks for the existence of the Files: field before processing it, only handling entries that contain this field.

Changes:

  • Add check_and_clean_partial_download() function to detect and remove incomplete downloads in skel_path
  • Call check_and_clean_partial_download() before need_update() for both Packages and Sources processing
  • Add existence check for Files: field in Sources index processing

This commit addresses two issues:

1. Fix partial download recovery:
   - When network errors occur during download, some files in skel_path
     may be smaller than expected. Previously, apt-mirror would not
     re-download these incomplete files on subsequent runs, requiring
     manual deletion. Now, the script automatically detects and removes
     incomplete temporary files before checking if an update is needed.

2. Handle missing Files field in Sources index:
   - Some source package index files don't contain a Files: field,
     which caused "Use of uninitialized value" warnings. While these
     warnings didn't affect synchronization, they were noisy. The code
     now checks for the existence of the Files: field before processing
     it, only handling entries that contain this field.

Changes:
- Add check_and_clean_partial_download() function to detect and remove
  incomplete downloads in skel_path
- Call check_and_clean_partial_download() before need_update() for both
  Packages and Sources processing
- Add existence check for Files: field in Sources index processing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant