Skip to content

chore: remove commander dependency #1908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 1 commit into from
May 4, 2026
Merged

chore: remove commander dependency #1908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,10 @@
"@sentry/electron": "^7.12.0",
"algoliasearch": "^4.12.0",
"classnames": "^2.2.6",
"commander": "^7.1.0",
"electron-default-menu": "^1.0.2",
"electron-squirrel-startup": "^1.0.0",
"extract-zip": "^2.0.1",
"fs-extra": "^9.1.0",
"getos": "^3.2.1",
"mobx": "^6.5.0",
"mobx-react": "^7.3.0",
"monaco-editor": "^0.22.0",
Expand Down Expand Up @@ -97,7 +95,6 @@
"@tsconfig/node22": "^22.0.2",
"@types/classnames": "^2.2.11",
"@types/fs-extra": "^9.0.7",
"@types/getos": "^3.0.1",
"@types/node": "^22.19.1",
"@types/parse-env-string": "^1.0.2",
"@types/react": "^16.14.0",
Expand Down
193 changes: 0 additions & 193 deletions src/main/command-line.ts
View file
Open in desktop

This file was deleted.

11 changes: 2 additions & 9 deletions src/main/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import {
} from 'electron';

import { setupAboutPanel } from './about-panel';
import { processCommandLine } from './command-line';
import { setupContent } from './content';
import { setupDevTools } from './devtools';
import { setupDialogs } from './dialogs';
Expand All @@ -34,8 +33,6 @@ import { setupVersions } from './versions';
import { getOrCreateMainWindow, mainIsReady } from './windows';
import { IpcEvents } from '../ipc-events';

let argv: string[] = [];

/**
* Handle the app's "ready" event. This is essentially
* the method that takes care of booting the application.
Expand Down Expand Up @@ -73,8 +70,6 @@ export async function onReady() {
// any IPC listeners are set up before they're used
mainIsReady();
await getOrCreateMainWindow();

processCommandLine(argv);
}

/**
Expand Down Expand Up @@ -200,9 +195,7 @@ export function onWindowsAllClosed() {
*
* Exported for testing purposes.
*/
export function main(argv_in: string[]) {
argv = argv_in;

export function main() {
// Handle creating/removing shortcuts on Windows when
// installing/uninstalling.
if (shouldQuit()) {
Expand All @@ -225,4 +218,4 @@ export function main(argv_in: string[]) {
});
}

main(process.argv);
main();
Loading