Conversation
dsanders11
approved these changes
May 4, 2026
ckerr
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reduces the scope of IPC exposed to the renderer process and adds input validation for filesystem-related handlers.
There were events in
ipcMainEventsthat silently accepted fire-and-forget messages from the renderer even though no handler consumed them, so they have been removed.Sender validation: The
IpcMainManagerconstructor now verifies that every inboundipcMain.onevent originates from a window tracked byBrowserWindow.fromWebContents. Messages from WebViews, sub-frames, or detached/untracked windows are silently dropped.Added input validation to three filesystem handlers before passing renderer-supplied values to
fsoperations.CLEANUP_DIRECTORY— rejects any path that does not resolve insideos.tmpdir(), preventing path traversal to arbitrary filesystem locations.DELETE_USER_DATA— rejects names containing path separators (/,path.sep) or.., so the renderer cannot escapeapp.getPath('appData').PATH_EXISTS— type-checks the argument before callingfs.existsSync.