Skip to content

test: re-enable test for preventing new windows #1919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsanders11 merged 2 commits into from
May 5, 2026
+16 −9
Merged

test: re-enable test for preventing new windows #1919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ee39a0
test: re-enable test for preventing new windows
dsanders11 May 5, 2026
218830d
test: fix test running after others
dsanders11 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 16 additions & 9 deletions tests/main/windows.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,11 @@ describe('windows', () => {
});

describe('getOrCreateMainWindow()', () => {
beforeEach(async () => {
const window = await getOrCreateMainWindow();
window.emit('closed');
});

it('creates a window on first call', async () => {
expect(browserWindows.length).toBe(0);
await getOrCreateMainWindow();
Expand All @@ -108,16 +113,18 @@ describe('windows', () => {
expect(createContextMenu).toHaveBeenCalled();
});

// FIXME: new test for setWindowOpenHandler
it.skip('prevents new-window"', async () => {
const e = {
preventDefault: vi.fn(),
};

it('sets a window open handler that denies and opens URL externally', async () => {
await getOrCreateMainWindow();
expect(browserWindows[0]).toBeTruthy();
(await getOrCreateMainWindow()).webContents.emit('new-window', e);
expect(e.preventDefault).toHaveBeenCalled();
const win = browserWindows[0]!;
const handler = vi.mocked(win.webContents.setWindowOpenHandler).mock
.calls[0][0];
const result = handler({
url: 'https://example.com',
} as Electron.HandlerDetails);
expect(result).toEqual({ action: 'deny' });
expect(electron.shell.openExternal).toHaveBeenCalledWith(
'https://example.com',
);
});

it('prevents will-navigate"', async () => {
Expand Down
Loading