Open
Conversation
|
coverage: 88.4% (-0.09%) from 88.492% — build/remove-package-json-dep into main |
mlaurencin
approved these changes
May 5, 2026
jkleinsc
approved these changes
May 5, 2026
erickzhao
approved these changes
May 5, 2026
dsanders11
requested changes
May 6, 2026
Member
dsanders11
left a comment
dsanders11
left a comment
There was a problem hiding this comment.
One specific change requested inline, but overall I'd feel more comfortable with this change if we pulled it out into a helper util and added test coverage of it.
Comment on lines
+203
to
+204
| const res = await fetch(url, { headers }); | ||
| const data = (await res.json()) as { versions: Record<string, unknown> }; |
Member
There was a problem hiding this comment.
We need to check res.ok before parsing it as JSON.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin: remove
package-jsondependency.