client: allow announce custom port

[mayli]

No description provided.

[elektito]

Thank you for the PR. But I don't quite understand the purpose. We can set the tracker port through the announce_uri parameter of TrackerClient. For example:

client = TrackerClient(local_addr='udp://tracker.example.org:8000')

So there's no reason to pass port to the announce method. If we want to talk to multiple trackers, we should create multiple clients.

[mayli]

Thank you for the PR. But I don't quite understand the purpose. We can set the tracker port through the announce_uri parameter of TrackerClient. For example:

client = TrackerClient(local_addr='udp://tracker.example.org:8000')

So there's no reason to pass port to the announce method. If we want to talk to multiple trackers, we should create multiple clients.

This is not for the tracker port, it's to tell the client's local port, instead of using a random one allocated from UDP.

[elektito]

Just realized that line of code I had there was incorrect. It should be: client = TrackerClient(local_addr='udp://tracker.example.org:8000'). That was also incorrect in the README, which I've fixed.

But if you want is to use a different local port, I'm still not sure how that is supposed to work. We already have a socket with a port assigned to it. If we change the value in the message, the tracker would contact another port. Is your intention to have another socket to receive tracker response on?