Skip to content

Hook up the Reset flow to Verification when there is no recovery or other devices.#8024

Merged
pixlwave merged 3 commits into
developfrom
doug/reset-secrets-button
Apr 29, 2026
Merged

Hook up the Reset flow to Verification when there is no recovery or other devices.#8024
pixlwave merged 3 commits into
developfrom
doug/reset-secrets-button

Conversation

@pixlwave
Copy link
Copy Markdown
Member

@pixlwave pixlwave commented Apr 28, 2026

This PR makes the following changes:

  • Show a Reset button on KeyVerificationSelfVerifyWaitViewController when verifying your own device and there isn't any other devices, nor a recovery set up. This button comes straight from SecretsRecoveryWithPassphraseViewController so matches the style used elsewhere in the app. Fixes the blank view issue.
  • Fix the presentation of re-authentication from SecretsResetViewModel in the same way that #7874 was implemented. Fixes Unable to reset password on log in #7921.
  • Fix a bug from #7874 where tapping the web view's close button would just re-present authentication over and over.

Additionally I've made a change to re-authentication presentation in a second commit as the user had to swipe the MAS screen away (the close button didn't work).

  • Fix ReauthenticationCoordinator not dismissing the fallback view controller automatically: The password's UI alert controller does this automatically, so it makes sense to do the same with the fallback controller. I've added some guards on the bridge presenter to make sure that dismiss only works when something is presented as a safety measure.

Video of this in action when used on top of #8023

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-29.at.10.21.52.mov

@pixlwave pixlwave force-pushed the doug/reset-secrets-button branch from 13894b4 to 47377f0 Compare April 28, 2026 16:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 0% with 91 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.17%. Comparing base (5ae455e) to head (e71bfc6).
⚠️ Report is 10 commits behind head on develop.

Files with missing lines Patch % Lines
.../Modules/Secrets/Reset/SecretsResetViewModel.swift 0.00% 21 Missing ⚠️
...rification/Common/KeyVerificationCoordinator.swift 0.00% 15 Missing ⚠️
.../KeyVerificationSelfVerifyWaitViewController.swift 0.00% 15 Missing ⚠️
...n/ReauthenticationCoordinatorBridgePresenter.swift 0.00% 10 Missing ⚠️
...Reauthentication/ReauthenticationCoordinator.swift 0.00% 9 Missing ⚠️
...les/Secrets/Reset/SecretsResetViewController.swift 0.00% 7 Missing ⚠️
...odules/Secrets/Reset/SecretsResetCoordinator.swift 0.00% 6 Missing ⚠️
...ssSigning/Setup/CrossSigningSetupCoordinator.swift 0.00% 4 Missing ⚠️
...ait/KeyVerificationSelfVerifyWaitCoordinator.swift 0.00% 2 Missing ⚠️
...yWait/KeyVerificationSelfVerifyWaitViewModel.swift 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8024      +/-   ##
===========================================
+ Coverage    14.18%   15.17%   +0.99%     
===========================================
  Files         1815     1815              
  Lines       173949   119467   -54482     
  Branches     73699    47801   -25898     
===========================================
- Hits         24675    18130    -6545     
+ Misses      148603   100666   -47937     
  Partials       671      671              
Flag Coverage Δ
uitests 49.62% <ø> (-1.01%) ⬇️
unittests 8.79% <0.00%> (+0.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pixlwave pixlwave force-pushed the doug/reset-secrets-button branch from 47377f0 to 0a21a5c Compare April 29, 2026 09:10
@pixlwave pixlwave changed the title Show a Reset button when there is no recovery or other devices. Hook up the Reset flow to Verification when there is no recovery or other devices. Apr 29, 2026
@pixlwave pixlwave requested a review from Velin92 April 29, 2026 09:26
@pixlwave pixlwave marked this pull request as ready for review April 29, 2026 09:43
@pixlwave pixlwave merged commit 02dd8ab into develop Apr 29, 2026
8 of 9 checks passed
@pixlwave pixlwave deleted the doug/reset-secrets-button branch April 29, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to reset password on log in

2 participants