Hook up the Reset flow to Verification when there is no recovery or other devices.#8024
Merged
Conversation
13894b4 to
47377f0
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #8024 +/- ##
===========================================
+ Coverage 14.18% 15.17% +0.99%
===========================================
Files 1815 1815
Lines 173949 119467 -54482
Branches 73699 47801 -25898
===========================================
- Hits 24675 18130 -6545
+ Misses 148603 100666 -47937
Partials 671 671
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
47377f0 to
0a21a5c
Compare
Velin92
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
KeyVerificationSelfVerifyWaitViewControllerwhen verifying your own device and there isn't any other devices, nor a recovery set up. This button comes straight fromSecretsRecoveryWithPassphraseViewControllerso matches the style used elsewhere in the app. Fixes the blank view issue.SecretsResetViewModelin the same way that #7874 was implemented. Fixes Unable to reset password on log in #7921.Additionally I've made a change to re-authentication presentation in a second commit as the user had to swipe the MAS screen away (the close button didn't work).
Video of this in action when used on top of #8023
Simulator.Screen.Recording.-.iPhone.17.-.2026-04-29.at.10.21.52.mov