Merged
Conversation
The majority of `renderMainTab` is enpty for the call transfer dialog, so we may as well inkine the bits that aren't.
Now that this is unused for CallTransfer, we can simplify
eslint seems happy without this, and we shouldn't be disabling lints for a whole file anyway
dbkr
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some non-functional cleanup work in
InviteDialog.Currently
renderCallTransferDialogcallsrenderMainTab, but it turns out that the majority ofrenderMainTabis irrelevant toInviteKind.CallTransfer. We can simplify things a lot by just inlining the bits ofrenderMainTabthat we actually need.Also, remove a redundant eslint-disable line while we're here.