Prevent unnecessary downloads when quickly swiping through media#6439
Open
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
Open
Prevent unnecessary downloads when quickly swiping through media#6439bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
Conversation
Debounce download when quickly browsing through media files to prevent unnecessary downloads during fast swiping.
Contributor
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
bmarty
reviewed
Apr 1, 2026
| delay(300) | ||
| state.eventSink(MediaViewerEvents.LoadMedia(dataForPage)) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Hello, I do not really understand this code. To me LoadMedia is always triggered without any delay. Can you explain please?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Content
Debounce download when quickly swiping through media files to prevent unnecessary downloads.
Motivation and context
The media player would start download on each swipe, which would make a big queue for downloading and ultimately make the media player broken as you'd need to wait for all downloads to finish.
Screenshots / GIFs
Tests
Tested devices
Checklist