Skip to content

Show space badges in the room list#6536

Open
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn:feature/space-badges
Open

Show space badges in the room list#6536
bxdxnn wants to merge 1 commit intoelement-hq:developfrom
bxdxnn:feature/space-badges

Conversation

@bxdxnn
Copy link
Copy Markdown
Contributor

@bxdxnn bxdxnn commented Apr 5, 2026

Content

Show parent spaces avatars next to a room's name in the room list

Motivation and context

When you have a big room list, this helps with navigation.

Screenshots / GIFs

Tests

  • Test that you can see all parent spaces
  • Test that they're updated when room's space membership changes

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bxdxnn bxdxnn requested a review from a team as a code owner April 5, 2026 12:11
@bxdxnn bxdxnn requested review from ganfra and removed request for a team April 5, 2026 12:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 5, 2026

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Apr 5, 2026
@bxdxnn
Copy link
Copy Markdown
Contributor Author

bxdxnn commented Apr 5, 2026

@americanrefugee

It's not clear how to handle when the room's name is too long and/or the space list is too long, should the badges list be wrapped?

@americanrefugee
Copy link
Copy Markdown

I don't fully understand what you want to do or why. Can you please include a screenshot for more context? Thanks!

@mxandreas
Copy link
Copy Markdown
Contributor

mxandreas commented Apr 8, 2026

I don't fully understand what you want to do or why. Can you please include a screenshot for more context? Thanks!

@americanrefugee I have taken a look. The idea is to have a small "thumbnail" next of the room name which indicates the space(s) the room belongs to. While the information as such can be useful, my main concern is that it will be another piece of information in the room list which people use throughout the day and "cluttering" it may just make it harder to read. Given the whole spaces design is quite knew and we are still in the phase of collecting feedback, I'd wait to get more of it, and then decide what enhancements to make.

Screenshot_20260407_163014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants