Bail out if admin_unsafely_bypass_quarantine was used by a non-admin#19639
Merged
anoadragon453 merged 4 commits intodevelopfrom Apr 17, 2026
Merged
Bail out if admin_unsafely_bypass_quarantine was used by a non-admin#19639anoadragon453 merged 4 commits intodevelopfrom
admin_unsafely_bypass_quarantine was used by a non-admin#19639anoadragon453 merged 4 commits intodevelopfrom
Conversation
Previously the code would send an error back to the client, but would continue executing and fetch the remote media anyhow. This isn't too much of an issue, as remote media must already be cached locally in order to quarantine it in the first place.
erikjohnston
approved these changes
Apr 13, 2026
Prevent types from being evaluated at runtime. The alternative to just quoting the type.
velikopter
reviewed
Apr 17, 2026
| access_token=non_admin_user_tok, | ||
| await_result=False, | ||
| ) | ||
| self.pump() |
Contributor
There was a problem hiding this comment.
Whats the need for this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the code would send an error back to the client, but would continue executing and fetch the remote media anyhow.
This isn't too much of an issue, as remote media must already be cached locally in order to quarantine it in the first place.
Introduced in #19275
Pull Request Checklist
EventStoretoEventWorkerStore.".code blocks.