Support deleting media from non-local storage providers#19665
Open
nexy7574 wants to merge 4 commits intoelement-hq:developfrom
Open
Support deleting media from non-local storage providers#19665nexy7574 wants to merge 4 commits intoelement-hq:developfrom
nexy7574 wants to merge 4 commits intoelement-hq:developfrom
Conversation
Also implements it for `FileStorageProviderBackend` Signed-off-by: timedout <git@nexy7574.co.uk>
Signed-off-by: timedout <git@nexy7574.co.uk>
Signed-off-by: timedout <git@nexy7574.co.uk>
Signed-off-by: timedout <git@nexy7574.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new method,
deleteto theStorageProviderabstract base class. Also implements it forFileStorageProviderBackend. Downstream this is used in matrix-org/synapse-s3-storage-provider#153This change will allow external storage providers, such as synapse-s3-storage-provider, to delete media from their stores when media is removed. Previously, only media in the local provider would be removed, which means that deployments that stored their media on S3 would end up with dangling files, wasting storage.
Discussed in
#synapse-dev:matrix.orgPull Request Checklist
EventStoretoEventWorkerStore.".code blocks.