Fix crash when sending file from terminal; Silence some warnings

[jeremypw]

• Use Gee.ArrayList instead of File[] - this stopped the crash
• Ensure the ObjectManager has finished initializing before sending files. This ensures certain functions' requirements are met before they are called

This makes the scan_and_send_files function wait in Idle loop until object_manager flags it is ready - is there a more elegant way?

[zeebok]

Haven't tested but the code changes make sense

Significant changes due to merging main - needs to be checked and tested again.

[jeremypw]

@zeebok Thanks for looking at this! It is some time since I last visited it and there have been significant changes in main which I have merged in but am not sure if it is correct. I cannot test on OS8 at the moment as I run that in a VM. I'll try to test in Horus though. This doesn't seem to be linked to a particular issue and I cannot remember now how I reproduced the crash 😞

[jeremypw]

Well, I managed to transfer a file to my Android phone OK using Files and also using bt-obex -p from the terminal. Hopefully someone can test this further on OS8.

[leonardo-lemos]

@jeremypw Can you provide more info about how to reproduce the crash, please?

[jeremypw]

@leonardo-lemos Sorry I cannot remember now exactly what prompted this PR, but I just tried installing the main branch on OS7.1 and running bt-obex -p <devicename> <path-to-file> when the device was not connected and it successfully connected to the device and transferred the file so I think maybe the issue has been fixed elsewhere. I am going to close this for now.

[jeremypw]

I think if may be something to do with running io.elementary.bluetooth --send=<path> in the terminal. This does not seem to work on Horus. Nothing happens at all - the io.elementary.bluetooth process does not crash tho.

I'll look into it further.