Skip to content

ReceiverDialog: GTK4 prep#30

Merged
danirabbit merged 3 commits intomainfrom
danirabbit/receiverdialog-gtk4prep
Apr 17, 2026
Merged

ReceiverDialog: GTK4 prep#30
danirabbit merged 3 commits intomainfrom
danirabbit/receiverdialog-gtk4prep

Conversation

@danirabbit
Copy link
Copy Markdown
Member

  • Rename to ReceiverDialog so its clear what kind of object this is in other classes
  • Bump copyright header
  • Fix minor codestyle issues like whitespace
  • Use child property
  • Don't set image size, just its gicon

@danirabbit danirabbit requested a review from a team February 26, 2025 21:28
@danirabbit danirabbit moved this to Needs Review in GTK4 Porting Feb 26, 2025
Copy link
Copy Markdown
Contributor

@jeremypw jeremypw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good an unlikely to cause regressions but I am unable to test as file receiving does not work with my Android phone on Horus and I am only I am only able to run OS8 in A VM.

@zeebok
Copy link
Copy Markdown

zeebok commented Jun 4, 2025

Conflicts to resolve now

@danirabbit danirabbit requested a review from a team April 15, 2026 16:37
@danirabbit danirabbit merged commit 76ab3e5 into main Apr 17, 2026
4 checks passed
@danirabbit danirabbit deleted the danirabbit/receiverdialog-gtk4prep branch April 17, 2026 20:33
@github-project-automation github-project-automation Bot moved this from Needs Review to Done in GTK4 Porting Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants