Skip to content

Allow some shell shortcuts to reach terminal #1697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
jeremypw wants to merge 8 commits into
base: master
Choose a base branch
from
+28 −0
Draft

Allow some shell shortcuts to reach terminal #1697

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eeb1e8e
Disable Ctrl-R actions when terminal focused
jeremypw Feb 23, 2026
7f619b5
Disable Ctrl-Z actions when terminal focused
jeremypw Feb 23, 2026
b5c501c
Disable Ctrl-u action when terminal focused
jeremypw Feb 23, 2026
c0d94f0
Disable Ctrl-k actions when terminal focused
jeremypw Feb 23, 2026
1521f93
Disable Ctrl-l action while terminal is focused
jeremypw Feb 23, 2026
e7dc5a8
Merge branch 'master' into jeremypw/terminal-pane/ctrl-r
jeremypw Mar 2, 2026
de9f94e
Merge branch 'master' into jeremypw/terminal-pane/ctrl-r
jeremypw May 16, 2026
b10536d
Merge branch 'master' into jeremypw/terminal-pane/ctrl-r
jeremypw Jun 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions src/MainWindow.vala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -532,6 +532,9 @@ namespace Scratch {
visible = false
};

terminal.terminal.focus_in_event.connect (on_terminal_focus_change);
terminal.terminal.focus_out_event.connect (on_terminal_focus_change);

var view_grid = new Gtk.Grid () {
orientation = Gtk.Orientation.VERTICAL
};
Expand Down Expand Up @@ -745,6 +748,27 @@ namespace Scratch {
toolbar.share_menu_button.sensitive = val;
}

private bool on_terminal_focus_change () {
var focused = terminal.terminal.has_focus;
//<Control>r +- shift
Utils.action_from_group (ACTION_SHOW_REPLACE, actions).set_enabled (!focused);
Utils.action_from_group (ACTION_RESTORE_PROJECT_DOCS, actions).set_enabled (!focused);
//<Control>z +- shift
Utils.action_from_group (ACTION_UNDO, actions).set_enabled (!focused);
Utils.action_from_group (ACTION_REDO, actions).set_enabled (!focused);

//<Control>u
Utils.action_from_group (ACTION_TO_UPPER_CASE, actions).set_enabled (!focused);

//<Control>k +- shift
Utils.action_from_group (ACTION_DUPLICATE_TAB, actions).set_enabled (!focused);
Utils.action_from_group (ACTION_CLEAR_LINES, actions).set_enabled (!focused);

//<Control>l
Utils.action_from_group (ACTION_TO_LOWER_CASE, actions).set_enabled (!focused);
return false;
}

// Get current document
public Scratch.Services.Document? get_current_document () {
return document_view.current_document;
Expand Down Expand Up @@ -1292,6 +1316,10 @@ namespace Scratch {
}

private void action_show_replace (SimpleAction action) {
if (terminal.terminal.has_focus) {
return;
}

find ();
// May have to wait for the search bar to be revealed before we can grab focus

Expand Down