Skip to content

Gtk4 prep: Avoid using focus event#1730

Open
jeremypw wants to merge 6 commits into
masterfrom
jeremypw/gtk4prep/avoid-focus-event
Open

Gtk4 prep: Avoid using focus event#1730
jeremypw wants to merge 6 commits into
masterfrom
jeremypw/gtk4prep/avoid-focus-event

Conversation

@jeremypw

@jeremypw jeremypw commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

In these cases, it is sufficient to listen to changes to the "in-focus" property of the widget (there are no focusable child widgets). This code should compile in Gtk4 without change.

@jeremypw jeremypw marked this pull request as ready for review June 20, 2026 16:22
@jeremypw jeremypw added this to the 8.3.2 milestone Jun 20, 2026
Comment thread src/Widgets/SearchBar.vala Outdated
Comment thread src/Services/Document.vala Outdated
Comment thread src/Services/Document.vala
@jeremypw jeremypw requested a review from danirabbit June 20, 2026 19:22
@jeremypw

Copy link
Copy Markdown
Collaborator Author

@danirabbit Thanks for the review. I retained that questionable text_buffer == null test as changing that is outside the scope of this PR and I am unsure whether it is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants