Open
Conversation
lenemter
force-pushed
the
lenemter/show-git-hash-in-ver
branch
from
c4904a4 to
fce7ac8
Compare
ryonakano
reviewed
Apr 12, 2026
lenemter
force-pushed
the
lenemter/show-git-hash-in-ver
branch
2 times, most recently
from
64483d2 to
76d1f3e
Compare
lenemter
force-pushed
the
lenemter/show-git-hash-in-ver
branch
2 times, most recently
from
db02bad to
37342d6
Compare
lenemter
force-pushed
the
lenemter/show-git-hash-in-ver
branch
from
37342d6 to
bc7246a
Compare
ryonakano
reviewed
Apr 12, 2026
| env: | ||
| DESTDIR: out | ||
| run: | | ||
| git config --global --add safe.directory "$(pwd)" |
Member
There was a problem hiding this comment.
Suggested change
| git config --global --add safe.directory "$(pwd)" | |
| git config --global --add safe.directory "$GITHUB_WORKSPACE" |
It seems like we use this environment variable in other places. Also this is (slightly) more efficient than a command substitution.
| env: | ||
| DESTDIR: out | ||
| run: | | ||
| git config --global --add safe.directory "$(pwd)" |
Member
There was a problem hiding this comment.
Suggested change
| git config --global --add safe.directory "$(pwd)" | |
| git config --global --add safe.directory "$GITHUB_WORKSPACE" |
Same here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should make it easier for early access users to get the accurate version information