WindowManager/ShellClients: Explicitly override window group#2826
Open
leolost2605 wants to merge 2 commits intomainfrom
Open
WindowManager/ShellClients: Explicitly override window group#2826leolost2605 wants to merge 2 commits intomainfrom
leolost2605 wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To select the correct group for shell windows the window manager currently has to know what the possibilities are and then query the shell clients manager to see if the windows are one of that.
It also only works if we know the correct info about the windows before their window actor is turning visible.
Instead of this hacky solution we introduce a
override_window_groupin the wm. This is then called by the shellclientsmanager at that moment when it knows what the window will be.This has a few advantages: