Skip to content

WindowManager/ShellClients: Explicitly override window group#2826

Open
leolost2605 wants to merge 2 commits intomainfrom
leolost/explicit-override-window-group
Open

WindowManager/ShellClients: Explicitly override window group#2826
leolost2605 wants to merge 2 commits intomainfrom
leolost/explicit-override-window-group

Conversation

@leolost2605
Copy link
Copy Markdown
Member

@leolost2605 leolost2605 commented Apr 23, 2026

To select the correct group for shell windows the window manager currently has to know what the possibilities are and then query the shell clients manager to see if the windows are one of that.
It also only works if we know the correct info about the windows before their window actor is turning visible.

Instead of this hacky solution we introduce a override_window_group in the wm. This is then called by the shellclientsmanager at that moment when it knows what the window will be.

This has a few advantages:

  • We have a clear interface for how to handle changing the group of a window that also makes sure the wm knows about it and doesn't try to mess with it.
  • It scales a lot better by allowing the actual places that know that the window should be somewhere else to change its group instead of the wm having to query everywhere. This will be useful for example with the osk which will also need its own group.
  • It reduces the public api the shellclientsmanager has to expose
  • It should finally fix the wingpanel sometimes being invisible in the multitasking view which for me still happens even after Move windows to shell group when window type changes #2646
  • The second commit can remove some now unecessary code

@leolost2605 leolost2605 requested a review from a team April 23, 2026 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant