GestureController: Disconnect timeline signals when removing#2829
Open
leolost2605 wants to merge 1 commit intomainfrom
Open
GestureController: Disconnect timeline signals when removing#2829leolost2605 wants to merge 1 commit intomainfrom
leolost2605 wants to merge 1 commit intomainfrom
Conversation
The timeline might stay alive for a bit and send a stop signal which would lead to a triggered assertion because we don't expect that. Therefore make sure we explicitly disconnect signals and don't trust on the timeline finalizing and auto disconnecting the signals.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeline might stay alive for a bit and send a stop signal which would lead to a triggered assertion because we don't expect that. Therefore make sure we explicitly disconnect signals and don't trust on the timeline finalizing and auto disconnecting the signals.
Fixes a crash when assertions are enabled.