Skip to content

Styles: Add terminal style class#864

Open
wpkelso wants to merge 7 commits intomainfrom
wpkelso/styles/terminal
Open

Styles: Add terminal style class#864
wpkelso wants to merge 7 commits intomainfrom
wpkelso/styles/terminal

Conversation

@wpkelso
Copy link
Copy Markdown
Member

@wpkelso wpkelso commented May 13, 2025

  • Deprecate Granite.STYLE_CLASS_TERMINAL
  • Add undocumented terminal style class
image

@wpkelso wpkelso requested a review from a team May 13, 2025 18:53
@wpkelso wpkelso changed the title Add Granite.CssClass.TERMINAL Styles: Add Granite.CssClass.TERMINAL May 13, 2025
@wpkelso
Copy link
Copy Markdown
Member Author

wpkelso commented May 14, 2025

Open question: Might this be better used as an internal style to a new TerminalView widget? Every time this is used in our repos, it's in the context of a ScrollBox with a TextView child.

@danirabbit
Copy link
Copy Markdown
Member

danirabbit commented May 14, 2025

Yeah I actually wonder if we should have this public facing at all. Because we mainly use it in messagedialog. The sideload and installer cases I think I'd be okay with them using undocumented API or just supplying their own styles. I'm not sure this style is actually useful outside of system apps since everyone else is expected to use MessageDialog

@wpkelso
Copy link
Copy Markdown
Member Author

wpkelso commented May 14, 2025

I'm happy with the style class being undocumented or internal. I think it's still worth it to abstract all of it into a widget, as even in the system apps and widgets the use cases for a terminal view are so similar that it should make the code cleaner. I've started another branch off this one to play around with that idea in #867

@wpkelso wpkelso changed the title Styles: Add Granite.CssClass.TERMINAL Styles: Add terminal style class Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants