Open
Conversation
This was referenced Oct 5, 2025
zeebok
approved these changes
Apr 1, 2026
Contributor
zeebok
left a comment
zeebok
left a comment
There was a problem hiding this comment.
I am not totally familiar with the notification system but the code looks good to me
ryonakano
reviewed
Apr 3, 2026
| buttons = new GenericArray<Notification.Button?> (0) | ||
| }; | ||
|
|
||
| if (!Application.settings.get_boolean ("do-not-disturb") || notification.priority == GLib.NotificationPriority.URGENT) { |
Member
There was a problem hiding this comment.
Probably we can check this condition earlier in this method so that the following code is less nested?
| } | ||
|
|
||
| ~PortalProxy () { | ||
| connection.unregister_object (server_id); |
Member
There was a problem hiding this comment.
I guess we should unregister only when we successfully registered in the constructor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is currently impossible to implement notification portal fully inside the notification server itself because portals need to be launched by systemd, but our notification server need to be launched by gala. For now we can make portals forward notification requests to proxy dbus interface, which in OS 9 will allow us to move portal implementation fully inside notification server with minimal changes.