feat(ui): CommandPalette (⌘K spotlight) + GitHub-style Callout#3
Open
Srikar Sunchu (srikarsunchu) wants to merge 2 commits into
Open
feat(ui): CommandPalette (⌘K spotlight) + GitHub-style Callout#3Srikar Sunchu (srikarsunchu) wants to merge 2 commits into
Srikar Sunchu (srikarsunchu) wants to merge 2 commits into
Conversation
Builds the command palette from the 1b mockup on the Base UI Dialog primitive (no new deps): grouped results, query filtering, arrow-key navigation, Enter/click select. Stories cover the default open state (with a11y play test) and a global ⌘K/Ctrl+K shortcut wiring. Co-authored-by: Cursor <cursoragent@cursor.com>
Drops the tinted surface and outer border for a plain 3px left rule; the icon + label line is tinted in the tone color and the body renders in the regular foreground. Important now uses the speech-bubble icon (MessageSquareWarning) instead of duplicating Info. API unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The author of this PR, srikarsunchu, is not an activated member of this organization on Codecov. |
Baasil Ali (baasilali)
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CommandPalette— the ⌘K spotlight search overlay from the direction-1b docs mockup. Built on the existing Base UIDialogprimitive (no new dependencies), themed from@elide/tokens. Supports grouped results (Pages / Actions), live query filtering, ↑/↓ keyboard navigation, Enter/click select, and Esc to close. Exported from@elide/uiwithCommandGroup/CommandItemtypes.Docs/CommandPalette: a default-open state with an a11yplaytest (dialog role + labelled search input), and aWithGlobalShortcutstory wiring a real ⌘K/Ctrl+K listener with aplaytest that triggers it.Calloutrestyle — matches the GitHub admonition anatomy: plain 3px left rule (no tinted surface, radius, or outer border), icon + label line tinted in the tone color, body in regular foreground.importantnow uses the speech-bubbleMessageSquareWarningicon. Component API unchanged, so existing stories and consumers work as-is.Test plan
Docs/CommandPalette/Default: filtering, arrow-key navigation, Enter select, Esc closeDocs/CommandPalette/WithGlobalShortcut: ⌘K / Ctrl+K toggles the paletteplaytests pass (a11y roles/names, shortcut wiring)Docs/Callout/All Tones: all five tones render the new left-rule style in light and darkMade with Cursor