fix: remove syntax dep, highlight diffs inline#23
Merged
Conversation
Removes the `syntax` package and its transitive deps (tokenizr, sax) which failed to bundle correctly for GitHub Actions runners. Diff colorization is now handled inline in formatDiff. Signed-off-by: melodicore <lauri@elide.dev>
Signed-off-by: melodicore <datafox@datafox.me>
Lauri "datafox" Heino (melodicore)
requested a review
from Sam Gammon (sgammon)
as a code owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
syntaxpackage and its transitive dependencies (tokenizr,sax) which failed to bundle correctly on GitHub Actions runners due to the Browserify bundle's externalrequire()fallback hitting Node's CJS loader with nonode_modulespresentformatDiff:---/+++lines dimmed,@@hunk headers cyan,+lines green,-lines red