Skip to content

feat: make crucial processes significant and temporary #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Draggu wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: make crucial processes significant and temporary #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/gen_lsp.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,9 @@ defmodule GenLSP do
id: __MODULE__,
start: {__MODULE__, :start_link, [opts]},
type: :worker,
restart: :permanent,
shutdown: 500
restart: :temporary,
shutdown: 500,
significant: true
}
end

Expand Down
2 changes: 1 addition & 1 deletion lib/gen_lsp/buffer.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ defmodule GenLSP.Buffer do
@moduledoc """
The data buffer between the LSP process and the communication channel.
"""
use GenServer
use GenServer, restart: :temporary, significant: true

require Logger

Expand Down
8 changes: 6 additions & 2 deletions lib/gen_lsp/test.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,9 @@ defmodule GenLSP.Test do

buffer =
start_supervised!({GenLSP.Buffer, communication: {GenLSP.Communication.TCP, [port: 0]}},
id: buffer_id
id: buffer_id,
# The test supervisor only supports auto_shutdown: :never, so we override it to avoid conflicts
significant: false
)

assigns = start_supervised!(GenLSP.Assigns, id: assigns_id)
Expand All @@ -61,7 +63,9 @@ defmodule GenLSP.Test do
start_supervised!(
{mod,
Keyword.merge([buffer: buffer, assigns: assigns, task_supervisor: task_supervisor], opts)},
id: lsp_id
id: lsp_id,
# The test supervisor only supports auto_shutdown: :never, so we override it to avoid conflicts
significant: false
)

%{
Expand Down
Loading