perf: prefer recursion over multiple Keyword.has_key?#129
Merged
mhanberg merged 1 commit intoelixir-tools:mainfrom Apr 15, 2026
Merged
perf: prefer recursion over multiple Keyword.has_key?#129mhanberg merged 1 commit intoelixir-tools:mainfrom
Keyword.has_key?#129mhanberg merged 1 commit intoelixir-tools:mainfrom
Conversation
Perhaps surprisingly, using tail recursion is generally faster than Keyword.has_key? by about 10%. In this case though the most important thing is that we iterate over the list only once, instead of 2-3 times. The benchmark shows 7-8% improvement on parsing files.
Keyword.has_key?Keyword.has_key?
Contributor
|
Can you share the benchmarking method you are using? Could be useful for the repo. |
Contributor
Author
|
I used existing bench.exs with some minor modifications and ran it before and after the changes. So not anything super-scientific, but few runs like that gave generally similar results. For this PR I also created a standalone test with Benchee to see that recursive version is actually faster than Keyword.has_key? (although Benchee warns that for such fast operations it might not be super accurate). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less obvious (for me) than #128, but also seems like a quick perf win. Perhaps surprisingly, using tail recursion is generally faster than Keyword.has_key? by about 10%. In this case though the most important thing is that we iterate over the list only once, instead of 2-3 times.
The benchmark shows 7-8% improvement on parsing files.