Add magic_bytes validation example documentation#146
Open
leftstanding wants to merge 3 commits intoelixir-waffle:masterfrom
Open
Add magic_bytes validation example documentation#146leftstanding wants to merge 3 commits intoelixir-waffle:masterfrom
leftstanding wants to merge 3 commits intoelixir-waffle:masterfrom
Conversation
leftstanding
commented
Apr 15, 2026
Author
There was a problem hiding this comment.
📓 This was primarily for my own verification that everything wired up and worked correctly. I don't think we would want to keep this, and the test dependency, but since it did add some coverage and validation I figure I can leave it open to discussion before I revert it.
Member
|
Congrats on releasing the package. Considering most users are on the default validation, I would like to skip on adding the package to the dependency list. Added tests should also be a concern of a package. Can we just update the validation function docs, so it links to the hex.pm of magic_bytes package? p.s. sorry for a delayed reply |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #14