Skip to content

fix(omnivoice): drop -Wshadow to unblock LLAMA_FATAL_WARNINGS (CI 3rd-party)#21

Merged
lalalune merged 1 commit into
mainfrom
eliza/omnivoice-drop-wshadow
May 19, 2026
Merged

fix(omnivoice): drop -Wshadow to unblock LLAMA_FATAL_WARNINGS (CI 3rd-party)#21
lalalune merged 1 commit into
mainfrom
eliza/omnivoice-drop-wshadow

Conversation

@lalalune
Copy link
Copy Markdown
Member

Summary

PR #18 unblocked the multi-line-comment failure in CI (3rd-party). The next layer of failure exposed under -DLLAMA_FATAL_WARNINGS=ON:

ggml-backend.h:427: 'ggml_backend_graph_copy' hides constructor for 'struct ggml_backend_graph_copy'
llama-arch.h:623:   declaration of 'arch' shadows a member of 'LLM_TN'
llama-adapter.h:60: declaration of 'a'/'b' shadows a member of 'llama_adapter_lora_weight'

All three are in upstream llama.cpp headers, but omnivoice_lib enabled -Wshadow on its own translation units which pulled in those headers, and -DLLAMA_FATAL_WARNINGS=ON escalated them to -Werror.

Drop -Wshadow from omnivoice_lib. Keep -Wall -Wextra -Wconversion (and the -Wno-* suppressions) so omnivoice's own code is still warning-checked. The omnivoice shared library and omnivoice-test-abi-c already don't enable -Wshadow.

Test plan

  • CI (3rd-party) ubuntu-24-llguidance green
  • Other CI lanes unaffected (omnivoice still compiles with -Wall/-Wextra)

omnivoice_lib sources include llama's private headers
(src/llama-arch.h, src/llama-adapter.h, ...) and the public
ggml-backend.h. None of those are shadow-clean upstream:

  ggml-backend.h:427: 'ggml_backend_graph_copy' hides constructor
                      for 'struct ggml_backend_graph_copy'
  llama-arch.h:623:   declaration of 'arch' shadows a member of
                      'LLM_TN'
  llama-adapter.h:60: declaration of 'a'/'b' shadows a member of
                      'llama_adapter_lora_weight'

Under `-DLLAMA_FATAL_WARNINGS=ON` (CI 3rd-party / ubuntu-24-llguidance)
these become -Werror and break the build through no fault of
omnivoice's own sources.

Drop -Wshadow from omnivoice_lib's compile options. Keep -Wall
-Wextra -Wconversion so omnivoice's own code is still warning-checked.
omnivoice (shared) and omnivoice-test-abi-c already don't enable
-Wshadow.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 94a58d5c-3e92-4304-a045-22d36fa8c76c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eliza/omnivoice-drop-wshadow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lalalune lalalune merged commit c2f528f into main May 19, 2026
43 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant