Skip to content

ci(3rd-party): drop -Wconversion from omnivoice; widen debug src1_str buffer #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lalalune merged 1 commit into from
May 19, 2026
Merged

ci(3rd-party): drop -Wconversion from omnivoice; widen debug src1_str buffer #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion common/debug.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,11 @@ bool common_debug_cb_eval(struct ggml_tensor * t, bool ask, void * user_data) {
}
}

char src1_str[256] = { 0 };
// Buffer must fit `src1->name` (up to GGML_MAX_NAME, which omnivoice
// bumps to 128) plus the bracketed shape string. Stay well above the
// worst case so -Werror=format-truncation on CI 3rd-party doesn't
// reject a write the compiler can't prove is bounded.
char src1_str[512] = { 0 };
if (src1) {
snprintf(src1_str, sizeof(src1_str), "%s{%s}", src1->name, common_ggml_ne_string(src1).c_str());
}
Expand Down
9 changes: 5 additions & 4 deletions tools/omnivoice/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,12 +105,13 @@ if(MSVC)
target_compile_options(omnivoice_lib PRIVATE
/W4 /wd4100 /wd4505)
else()
# -Wshadow intentionally omitted: omnivoice sources include llama's
# private headers + the public ggml-backend.h, neither of which are
# shadow-clean upstream. Under -DLLAMA_FATAL_WARNINGS=ON those
# -Wshadow / -Wconversion intentionally omitted: omnivoice sources
# include llama's private headers (src/llama-arch.h, llama-adapter.h)
# and the public ggml-backend.h, none of which are shadow- or
# conversion-clean upstream. Under -DLLAMA_FATAL_WARNINGS=ON those
# warnings escalate to -Werror and break the 3rd-party CI lane.
target_compile_options(omnivoice_lib PRIVATE
-Wall -Wextra -Wconversion
-Wall -Wextra
-Wno-unused-parameter -Wno-unused-function -Wno-sign-conversion)
endif()

Expand Down
Loading