fix(omnivoice-codec): make main_impl static to satisfy -Wmissing-declarations#24
Merged
Merged
Conversation
…arations
`int main_impl(int, char**)` in tools/omnivoice/tools/omnivoice-codec.cpp
had no prior declaration. Under `-DLLAMA_FATAL_WARNINGS=ON` (CI
3rd-party / ubuntu-24-llguidance) this fails:
tools/omnivoice/tools/omnivoice-codec.cpp:158:5:
error: no previous declaration for 'int main_impl(int, char**)'
[-Werror=missing-declarations]
The sibling tool tools/omnivoice/tools/omnivoice-tts.cpp already marks
its main_impl static (line 411). Match it.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to PR #23.
tools/omnivoice/tools/omnivoice-codec.cpp:158definesint main_impl(int, char**)at file scope without prior declaration. Under-DLLAMA_FATAL_WARNINGS=ON(CI 3rd-party / ubuntu-24-llguidance) this fails:The sibling tool
omnivoice-tts.cppalready marks itsmain_implstatic (line 411). Match it.