Skip to content

fix(omnivoice-codec): make main_impl static to satisfy -Wmissing-declarations#24

Merged
lalalune merged 1 commit into
mainfrom
eliza/fix-omnivoice-codec-static
May 19, 2026
Merged

fix(omnivoice-codec): make main_impl static to satisfy -Wmissing-declarations#24
lalalune merged 1 commit into
mainfrom
eliza/fix-omnivoice-codec-static

Conversation

@lalalune
Copy link
Copy Markdown
Member

Follow-up to PR #23.

tools/omnivoice/tools/omnivoice-codec.cpp:158 defines int main_impl(int, char**) at file scope without prior declaration. Under -DLLAMA_FATAL_WARNINGS=ON (CI 3rd-party / ubuntu-24-llguidance) this fails:

tools/omnivoice/tools/omnivoice-codec.cpp:158:5: error: no previous declaration for 'int main_impl(int, char**)' [-Werror=missing-declarations]

The sibling tool omnivoice-tts.cpp already marks its main_impl static (line 411). Match it.

…arations

`int main_impl(int, char**)` in tools/omnivoice/tools/omnivoice-codec.cpp
had no prior declaration. Under `-DLLAMA_FATAL_WARNINGS=ON` (CI
3rd-party / ubuntu-24-llguidance) this fails:

  tools/omnivoice/tools/omnivoice-codec.cpp:158:5:
    error: no previous declaration for 'int main_impl(int, char**)'
    [-Werror=missing-declarations]

The sibling tool tools/omnivoice/tools/omnivoice-tts.cpp already marks
its main_impl static (line 411). Match it.
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 19, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 89c3b7a2-d02b-45e4-9176-bf6b20b4f3a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch eliza/fix-omnivoice-codec-static

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lalalune lalalune merged commit 96dd1a8 into main May 19, 2026
63 of 95 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant