Lazy-load Profile Sharing#1334
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
profile-share-loader.jswith one real retry and safe shell entry pointsWhy
Profile Sharing was loaded on every returning-user startup even when unused. Keeping only the route-aware loader in the startup graph reduces normal cold-load work without moving encryption, import, validation, or modal responsibilities out of the feature module.
Impact
The repeated cold-load reference moved from 450 requests / 1,915,305 compressed bytes / 5,918,162 decoded bytes to 449 requests / 1,908,488 compressed bytes / 5,890,321 decoded bytes. Profile Sharing still opens from every existing entry point, valid shared links still open automatically, and the full feature remains precached for offline first use.
Validation
./run-tests.sh: 486 Vitest tests, 391 Chromium tests, and 472 responsive-theme assertions passedThe coverage pass had the repository's known tour-overlay race in one import-benchmark test (390/391); that unchanged test passed immediately in isolation and the combined coverage ratchet passed. The first Firefox pass likewise hit the known delayed chat-onboarding race before the clean 3/3 rerun.