Skip to content

Lazy-load Profile Sharing#1334

Merged
elkimek merged 3 commits into
mainfrom
agent/lazy-load-profile-share
Jul 23, 2026
Merged

Lazy-load Profile Sharing#1334
elkimek merged 3 commits into
mainfrom
agent/lazy-load-profile-share

Conversation

@elkimek

@elkimek elkimek commented Jul 23, 2026

Copy link
Copy Markdown
Owner

Summary

  • add a cached profile-share-loader.js with one real retry and safe shell entry points
  • defer the full encrypted Profile Sharing graph until a shell, Settings, client-list, or valid shared-link action needs it
  • preserve startup/hash/query shared-link behavior and offline first use
  • remove the obsolete Data I/O composition wrapper and update the architecture map, contracts, service-worker shell, and app version
  • ratchet the reproducible cold-load reference and ceilings

Why

Profile Sharing was loaded on every returning-user startup even when unused. Keeping only the route-aware loader in the startup graph reduces normal cold-load work without moving encryption, import, validation, or modal responsibilities out of the feature module.

Impact

The repeated cold-load reference moved from 450 requests / 1,915,305 compressed bytes / 5,918,162 decoded bytes to 449 requests / 1,908,488 compressed bytes / 5,890,321 decoded bytes. Profile Sharing still opens from every existing entry point, valid shared links still open automatically, and the full feature remains precached for offline first use.

Validation

  • ./run-tests.sh: 486 Vitest tests, 391 Chromium tests, and 472 responsive-theme assertions passed
  • targeted Profile Sharing browser coverage: 8/8 passed
  • combined coverage: 67.11% functions (67.10% floor); Playwright: 90.92%
  • Firefox smoke: 3/3 passed on unchanged rerun
  • architecture: 465 modules, 0 cycles
  • cold-load benchmark repeated identically at 449 / 1,908,488 / 5,890,321

The coverage pass had the repository's known tour-overlay race in one import-benchmark test (390/391); that unchanged test passed immediately in isolation and the combined coverage ratchet passed. The first Firefox pass likewise hit the known delayed chat-onboarding race before the clean 3/3 rerun.

@elkimek
elkimek merged commit 73780af into main Jul 23, 2026
3 checks passed
@elkimek
elkimek deleted the agent/lazy-load-profile-share branch July 23, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant