Lazy-load Settings stylesheet#1335
Merged
Merged
Conversation
elkimek
marked this pull request as ready for review
July 24, 2026 07:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css/settings.cssuntil the first Settings or Tweaks action and load it concurrently with the existing lazy Settings moduleWhy
The Settings JavaScript was already lazy-loaded, but its 48 KB stylesheet still loaded for every returning-user startup even when Settings was never opened.
Impact
Identical same-machine cold-load runs improved from:
That saves one startup request, 7,645 transferred bytes, and 46,818 decoded bytes.
Validation
npm run test:playwright— 392 passed; responsive/theme suite 472 passednpm run test:firefox— 3 passed, including offline first-use Settingsnpm run typechecknpm run typecheck:checkjsnpm run architecture:checknpm run qualitygit diff --check