Forward all Opts to SSL config #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass all the supplied Opts, Erlang SSL will pick out only what it needs / understands. Don't discard other options user intends to pass for SSL config
yurrriq
reviewed
Feb 10, 2021
yurrriq
reviewed
Feb 10, 2021
| @@ -129,11 +129,13 @@ init([Opts]) -> | |||
| MinAcceptors = proplists:get_value(min_acceptors, Opts, 20), | |||
|
|
|||
| UseSSL = proplists:get_value(ssl, Opts, false), | |||
Member
There was a problem hiding this comment.
It seems the test is failing on this boolean.
Author
There was a problem hiding this comment.
It shouldn't fail as a result of my change, maybe something else?
Author
|
@yurrriq Hi. IS this change still being considered? |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass all the supplied Opts, Erlang SSL will pick out only what it needs / understands.
Don't discard other options user intends to pass for SSL config