Merged
Conversation
Bodo171
force-pushed
the
attempt-fix-actions
branch
from
6eeec31 to
e185081
Compare
correct glob str change paths rm 3.7 reqs change support v add eth-account ignore apis rm from travis ignore-glob flag
Bodo171
force-pushed
the
attempt-fix-actions
branch
from
e889768 to
b7f4bfa
Compare
denver79
reviewed
Oct 4, 2025
There was a problem hiding this comment.
In this file, the test step has a small issue. The run block for pytest contains two separate commands, which will cause the entire test suite to run twice.
The first pytest command should be removed, leaving only the one with the --ignore-glob flag.
There was a problem hiding this comment.
The eth-account package is missing from this file. It was added to pyproject.toml but not here.
This inconsistency can cause installation errors for environments that rely on requirements.txt. Please add the package to this file as well to keep the dependencies in sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.