Resolve focused build warnings - #901
Open
sfmskywalker wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR focuses on reducing/avoiding focused build warnings by tightening nullability contracts, aligning trimming annotations for DI-resolved types, and updating MudBlazor component attributes to satisfy newer analyzers.
Changes:
- Make localization provider contract non-null by falling back to the resource key when a translation is missing.
- Guard nullable login credentials prior to validator invocation and simplify OAuth2 credentials validation dependencies.
- Align trim annotations for backend API providers / workflow DI helpers and update MudBlazor attributes for analyzer compatibility.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/Elsa.Studio.Workflows/Services/DisconnectedWorkflowInstanceObserver.cs | Adjusts no-op observer event implementations (warning-related event initialization/contract handling). |
| src/modules/Elsa.Studio.Workflows.Core/Extensions/ServiceCollectionExtensions.cs | Adds trim annotations to generic DI registration helpers to satisfy trimming analysis. |
| src/modules/Elsa.Studio.Login/Services/OAuth2CredentialsValidator.cs | Removes unused options dependency from the OAuth2 credentials validator. |
| src/modules/Elsa.Studio.Login/Pages/Login/Login.razor.cs | Makes username/password nullable and rejects missing credentials before validating. |
| src/modules/Elsa.Studio.Labels/UI/Pages/Labels.razor | Updates MudButtonGroup attribute usage for MudBlazor v9 analyzer compatibility. |
| src/modules/Elsa.Studio.Labels/UI/Pages/Label.razor.cs | Adds class XML summary to reduce documentation warnings. |
| src/modules/Elsa.Studio.Labels/UI/Pages/Label.razor | Moves PanelClass to the tab panel to match updated MudBlazor API/analyzers. |
| src/modules/Elsa.Studio.Environments/Services/EnvironmentBackendApiClientProvider.cs | Aligns trim annotations on GetApiAsync<T> implementation with the interface contract. |
| src/modules/Elsa.Studio.Diagnostics.ConsoleLogs.Tests/SignalRConsoleLogObserverTests.cs | Aligns test stub provider signature with trim-annotated backend API provider contract. |
| src/modules/Elsa.Studio.Authentication.ElsaIdentity.UI/Pages/Login/Login.razor.cs | Makes username/password nullable and rejects missing credentials before validating. |
| src/framework/Elsa.Studio.Translations/ResxLocalizationProvider.cs | Makes GetTranslation non-null and falls back to the key when missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Warning inventory
Forced solution rebuild warning lines reduced from 2,734 to 2,636. Remaining warnings are existing repository-wide XML documentation, trim analyzer, and nullable warnings outside this focused patch.