Conversation
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
Signed-off-by: Arnau Mora <arnyminer.z@gmail.com>
|
Hi, thanks for your contribution. This is quite a big MR. I am hesistant to merge it without doing a thorough review of the commits. I will merge this in due time. |
|
I'll use this as a daily driver, to check if it has any major issues. |
|
Hi @ArnyminerZ . I pulled your changes to my local machine and I can't build it.
|
|
Yup, Guava is giving problems. Sometimes it does build, other times it just doesn't. I've tried different approaches, there's even a package Google released exclusively for this fix, but nothing works all the times :/ I was waiting for Google to release a fix. |
emansih
left a comment
There was a problem hiding this comment.
Hello this commit has "too many" changes that are whitespaces. The only "real" change is
if (isPermissionGranted(Manifest.permission.ACCESS_COARSE_LOCATION)) {
}
Could you please make sure the formatting is updated before I pull this commit? Thanks for your contribution
emansih
left a comment
There was a problem hiding this comment.
We don't need COARSE_LOCATION permission here since we have already requested FINE_LOCATION
Type of change
Migrations made
7.3.1337.4