fix: Optimise upload when allowOverwrite is true#123
Merged
lukemelia merged 1 commit intoember-cli-deploy:masterfrom Jul 10, 2022
Merged
Conversation
There is no need to try and figure out if a revision has already been deployed if we are going to overwrite it anyway. Let's save ourselves the network request!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to try and figure out if a revision has already been deployed
if we are going to overwrite it anyway. Let's save ourselves the network request!
What Changed & Why
Just a simple optimisation as described above. It's not going to make much difference because
since #119 it's been a single request to find if the revision exists. But it is still a little bit of work
that doesn't need to be done...
Related issues
#119 #121
PR Checklist
People
All maintainers :)