Add admin-configurable settings for marketplace#384
Add admin-configurable settings for marketplace#384kenny08gt wants to merge 15 commits intoemdash-cms:mainfrom
Conversation
Scope checkThis PR changes 751 lines across 27 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
|
All contributors have signed the CLA ✍️ ✅ |
🦋 Changeset detectedLatest commit: 187191d The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
I have read the CLA Document and I hereby sign the CLA |
Add changeset for marketplace settings
Overlapping PRsThis PR modifies files that are also changed by other open PRs:
This may cause merge conflicts or duplicated work. A maintainer will coordinate. |
|
There's a larger discussion around the future of Marketplace happening in #296 that's currently blocking moving forward on marketplace PRs. Feel free to jump into the conversation. |
What does this PR do?
Adds admin-configurable marketplace settings so site admins can define marketplace registry URLs from the EmDash admin UI instead of relying only on
astro.config.This PR introduces a new Settings → Marketplace screen that allows admins to:
Behavior is currently single active marketplace, but the stored settings shape is future-ready for multiple registries.
This PR also adds validation, UX clarification, and safety guidance:
http://localhost/127.0.0.1is only allowed for local development,Resolution precedence is now:
astro.configmarketplace valueCloses #
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output
Admin UI
/_emdash/admin/settings/marketplaceSettingsVerification
pnpm typecheck✅pnpm --silent lint:json | jq '.diagnostics | length'✅pnpm format✅packages/adminbrowser tests ✅Notes
pnpm testis still failing on unrelated existing auth test expectations in/Users/alanhurtarte/Projects/emdash/packages/core/tests/unit/auth/invite.test.ts,/Users/alanhurtarte/Projects/emdash/packages/core/tests/unit/auth/magic-link.test.ts, and/Users/alanhurtarte/Projects/emdash/packages/core/tests/unit/auth/signup.test.ts.