Fix plugin:activate and plugin:deactivate not called on setPluginStatus#394
Open
datienzalopez wants to merge 1 commit intoemdash-cms:mainfrom
Conversation
setPluginStatus rebuilt the hook pipeline but never called the lifecycle hooks, so plugin:activate and plugin:deactivate were silently skipped whenever a plugin was enabled or disabled via the admin UI. Now plugin:deactivate fires on the current pipeline (while the plugin is still registered) before it is removed, and plugin:activate fires after the pipeline is rebuilt with the plugin included — matching the sequence used by PluginManager.activate/deactivate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
setPluginStatus(called when enabling/disabling a plugin via the admin UI) rebuilt the hook pipeline but never invoked theplugin:activateorplugin:deactivatelifecycle hooks. This meant plugins relying onplugin:activateto schedule cron tasks or run setup logic would never see that hook fire.The fix follows the same ordering used by
PluginManager.activate/deactivate:plugin:deactivatefires on the current pipeline before the plugin is removed (while it's still registered)plugin:activatefires on the new pipeline after rebuild (while the plugin is now included)Closes #
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runAI-generated code disclosure
Screenshots / test output