feat: add Worker Mailer SMTP plugin#406
Open
RibasSu wants to merge 20 commits intoemdash-cms:mainfrom
Open
Conversation
Contributor
Scope checkThis PR changes 596 lines across 12 files. Large PRs are harder to review and more likely to be closed without review. If this scope is intentional, no action needed. A maintainer will review it. If not, please consider splitting this into smaller PRs. See CONTRIBUTING.md for contribution guidelines. |
🦋 Changeset detectedLatest commit: 813f27a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
While testing I first implemented this as a native, options-driven plugin in plugins: []. After the guidance in Discussions emdash-cms#245, this now follows the standard isolated Block Kit path in sandboxed: []. This also removes the older shape from the plugin docs/comments and requires SMTP connections to start secure over implicit TLS instead of upgrading from plaintext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a separate SMTP provider plugin for EmDash using
@workermailer/smtp, following the provider-per-plugin direction discussed in #245.This PR:
@emdash-cms/plugin-worker-maileremail:deliver/email:provideflowsettings
Related Discussion: #245
Closes #
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been runchanges a published package)
AI-generated code disclosure
Screenshots / test output
Validation run for this change:
pnpm --filter @emdash-cms/plugin-worker-mailer testpnpm --filter @emdash-cms/plugin-worker-mailer typecheckpnpm --filter @emdash-cms/plugin-worker-mailer buildpnpm run --filter @emdash-cms/demo-cloudflare typecheckpnpm --filter @emdash-cms/admin buildpnpm --filter @emdash-cms/demo-cloudflare buildpnpm typecheckpnpm --silent lint:json | jq '.diagnostics | length'pnpm testNotes:
pnpm --silent lint:json | jq '.diagnostics | length'returns2, both preexisting warnings:packages/admin/vitest.config.tspackages/core/src/astro/integration/vite-config.tspnpm testfails in existing core auth tests that expect/_emdash/api/...but currently receive/api/...:packages/core/tests/unit/auth/invite.test.tspackages/core/tests/unit/auth/magic-link.test.tspackages/core/tests/unit/auth/signup.test.tsThese failures are unrelated to the Worker Mailer plugin.