fix(schema): wire up FTS5 lifecycle in SchemaRegistry#407
Open
Pouf5 wants to merge 2 commits intoemdash-cms:mainfrom
Open
fix(schema): wire up FTS5 lifecycle in SchemaRegistry#407Pouf5 wants to merge 2 commits intoemdash-cms:mainfrom
Pouf5 wants to merge 2 commits intoemdash-cms:mainfrom
Conversation
- rebuildSearchIndex now gates on supports.includes("search") instead
of search_config.enabled, making supports the single source of truth
- createField calls rebuildSearchIndex when input.searchable is true
- deleteField drops FTS triggers before ALTER TABLE DROP COLUMN (SQLite
validates triggers on column drop), then rebuilds/drops FTS as needed
- deleteCollection drops the FTS virtual table before dropping the
content table to avoid orphaned tables
- updateCollection toggles FTS on/off when search is added/removed
from the supports array
Adds 11 failing tests covering all four bugs before implementing fixes.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
🦋 Changeset detectedLatest commit: 3e387d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@emdash-cms/admin
@emdash-cms/auth
@emdash-cms/blocks
@emdash-cms/cloudflare
emdash
create-emdash
@emdash-cms/gutenberg-to-portable-text
@emdash-cms/x402
@emdash-cms/plugin-ai-moderation
@emdash-cms/plugin-atproto
@emdash-cms/plugin-audit-log
@emdash-cms/plugin-color
@emdash-cms/plugin-embeds
@emdash-cms/plugin-forms
@emdash-cms/plugin-webhook-notifier
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds 11 failing tests covering all four bugs before implementing fixes.
Type of change
Checklist
pnpm typecheckpassespnpm --silent lint:json | jq '.diagnostics | length'returns 0pnpm testpasses (or targeted tests for my change)pnpm formathas been run2 pre-existing warnings in unrelated files (vite-config.ts:291, vitest.config.ts:7); git diff main on both is empty
AI-generated code disclosure
Screenshots / test output