Skip to content

Refresh landing page styling#6

Open
khoinguyenpham04 wants to merge 17 commits into
mainfrom
refresh-landing-page-styling
Open

Refresh landing page styling#6
khoinguyenpham04 wants to merge 17 commits into
mainfrom
refresh-landing-page-styling

Conversation

@khoinguyenpham04

Copy link
Copy Markdown

Summary

Refreshes the emdashcms.com marketing site with updated landing page, blog, header, footer, and responsive styling.

Preview:
https://emdashcms-com-redesign-preview.emdash-cms.workers.dev/

Changes

  • Adds reusable SiteHeader and SiteFooter components.
  • Updates landing sections: hero, features, FAQ, pricing, and testimonials.
  • Adds new landing assets under /public/landing.
  • Refreshes blog index and blog post layouts.
  • Improves page metadata, canonical URLs, article metadata, theme state, and CMS-driven link sanitization.
  • Keeps preview deployment config local-only via .gitignore.

Local Dev Setup

This PR keeps the useful parts of chore: fix local website dev setup.

  • Updates pnpm dev to run emdash dev, so local dev uses the EmDash workflow for migrations, seed handling, and type generation.
  • Moves Astro dependencies from temporary pkg.pr.new builds to published versions: astro@6.3.1 and @astrojs/cloudflare@13.7.0.
  • Updates Wrangler and Workers types to the matching current versions.
  • Adds pnpm-workspace.yaml build approvals for native/runtime dependencies required by local install.
  • Removes the old Cloudflare cache provider config because the current published @astrojs/cloudflare@13.7.0 package does not export @astrojs/cloudflare/cache.

We considered reverting this commit, but a full revert reintroduced install failures with current pnpm because the old pkg.pr.new lock entries lack tarball integrity metadata and package.json#pnpm.onlyBuiltDependencies is no longer honored. The setup changes are therefore kept as part of making the branch installable and reproducible.

Content Ownership

Production content should live in the EmDash admin, not in this PR.

  • seed/seed.json changes were intentionally restored to main.
  • This avoids overwriting or implying production content changes during deployment.
  • The PR focuses on code, layout, assets, and rendering behavior.

Validation

  • pnpm install --frozen-lockfile
  • pnpm typecheck
  • pnpm build
  • git diff --check

Notes

The preview Worker is deployed separately from production and is not included in the PR config. Production deploy should be done separately after review because wrangler.jsonc deploys beta, www, and apex routes together.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
emdashcms-com 655d3bd Jun 29 2026, 05:02 PM

@ascorbic ascorbic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few comments

Comment thread src/components/blocks/Testimonials.astro Outdated
Comment thread src/components/SiteFooter.astro Outdated
Comment thread src/components/SiteFooter.astro Outdated
Comment thread src/components/SiteFooter.astro Outdated
Comment thread src/components/SiteFooter.astro Outdated
Comment thread src/pages/blog/[slug].astro Outdated
Comment thread astro.config.mjs
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread package.json Outdated
Comment thread src/components/blocks/Hero.astro Outdated
Comment thread pnpm-workspace.yaml
Comment on lines +1 to +2
packages:
- "."

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will make it complain whenever you add a new package to the root. It can be removed: in latest pnpm you can use workspace files outside of monorepos by leaving out the packages list

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried removing this, but Cloudflare Workers Builds currently uses pnpm 10.11.1 and fails with packages field missing or empty without it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run corepack use pnpm@latest-11

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add emdash and @emdash-cms/* to minimumRelaseAgeExclude, like here:

https://github.com/emdash-cms/templates/blob/main/blog-cloudflare/pnpm-workspace.yaml#L13-L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants