Add inverted and shifted hartmann benchmark

[Hrovatin]

Add two new TL benchmarks:

• Inverted hartmann
• Hartmann shifted in one dimension

@kalama-ai

[kalama-ai]

Thanks, @Hrovatin for implementing the new benchmarks. Except some clean up, I am fine with the implementation.

[AVHopp]

Like the way this is going! Have some more ideas for further simplification

[AVHopp]

Some comments related to parts of the design that I still do not fully agree with resp. understand

[Scienfitz]

@Hrovatin any movement in this PR or should we close it?

[Hrovatin]

@Scienfitz still on my todo list to add your last two comments

[Scienfitz]

lgtm, last comments but otherwise ready for merge

[Scienfitz]

.optimizers might be a property that you cant just overwrite, please check

[Hrovatin]

This works from the code perspective - what do you mean by checking it @Scienfitz ?

h=ShiftedHartmann([0,0.1,1],dim=3)
print(h.optimizers,h._optimizers)
None None

They are only used in some botorch testing utils

[Scienfitz]

I think optimizers is a @property, so you shouldnt just overwrite it because properties are read-only

this is not (just) my opinion, mypy says the same, currently blocking your PR in CI

Imo there is a high chance that .optimizers just returns the value of ._optimizers + performs some checks

I did not check this myself, so you should

• "check" in the botorch code whether optimizers is really a property and is related to _optimizers the way I suspect
• you could comment out your .optimizers assignment line, instantiate your custm class and call the objects .optimizers and check that it coincides with your assigned ._optimizers

I suspect that removing the .optimizers line already does the job (not sure whether there is more mypy complains about, please check as well and always run or instruct your agent to run tox -e mypy-py310)

[AVHopp]

LGTM, only one general question and need a bit more time before I can approve

[AVHopp]

Some minor comments on the docstrings and type hints. Other than that, everything is either flagged by the CI (type error in mypy) or opened as a comment.