make history xdg base directory specification compliant#158
Conversation
|
I'm not sure why that fails on freebsd... |
|
FreeBSD has some macro magic going on with dirname If you want to use dirname, you will likely need to include a FreeBSD ifdef or something equivalent. The joy is overwhelming 😄 |
|
how is this even failing, the log seems fine. |
|
Ah, don't worry about it. I'll patch the CI so that the annotator only runs for the master branch. |
|
Well, at least it's not my fault this time then :D |
emersion
left a comment
emersion
left a comment
There was a problem hiding this comment.
Thanks for sending a PR, sorry for the long wait. Here are a few comments.
ghost
requested a review
from
|
Reported the FreeBSD bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251270 |
|
Do you want to wait for FreeBSD to fix the linked bug or is there something else holding up this PR? |
|
Sorry, I won't have time to look into this in the near future. |
5 participants
fixes #157