chore: make just check green — lint fixes + format sweep#130
Merged
Conversation
- clippy: replace a redundant closure in cmd_export.rs with the function itself
- shellcheck: use ${HOME} in verify-copilot-live.sh's error message (SC2088)
and find instead of ls for the projected session id (SC2012)
- rustfmt + prettier sweep: GitHub CI only runs test+clippy, so formatting
drifted across merged PRs; this restores 'cargo fmt --check' cleanliness
|
🔍 Preview deployed: https://f8b120fe.toolpath.pages.dev |
GitHub CI previously ran only cargo test + clippy, so rustfmt/prettier/ shellcheck drift merged unchecked (this branch's sweep is the cleanup). Adds a lint job running scripts/quality_gates.sh format shellcheck, and pins prettier (3.9.5) in site/package.json so the gate can't flap when a new prettier version changes formatting rules.
Replaces the bespoke test+clippy steps (and the interim lint job) with one job running scripts/quality_gates.sh --verbose — the same seven gates as 'just ci' — so the workflow can't drift from the justfile. Also disables SC2317 file-wide in quality_gates.sh: the gate_* functions are dispatched indirectly, which older shellcheck (ubuntu-latest) flags as SC2317 where newer flags SC2329; only the latter was suppressed, which is why the first CI run of the shellcheck gate failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running
just checkon main failed 2 of 7 gates. This makes it fully green and adds CI enforcement so it stays that way.Fixes
-D warnings): redundant closure incmd_export.rs— passstable_workspace_id_fordirectly toensure_workspace_storage_entry.scripts/verify-copilot-live.sh): SC2088 — spell the missing-config path with${HOME}instead of an unexpandable quoted~; SC2012 — derive the projected session id withfindinstead of parsingls.Format sweep (the other 30 files)
GitHub Actions CI only ran
cargo test+cargo clippy— not thequality_gates.shformat/shellcheck gates — so rustfmt/prettier cleanliness drifted across merged PRs. Verified against a pristine checkout of origin/main: plaincargo fmt --all --checkunder the pinned 1.94.0 toolchain reports 153 diffs in the same files (no rustfmt.toml involved; an alternate rustfmt 1.8.0 install reports the identical set, so it's not version skew — the code was committed without a fmt pass). Those hunks are formatting-only.CI enforcement (new)
lintjob to the workflow runningscripts/quality_gates.sh format shellcheckon every PR and push to main — same single source of truth asjust ci.prettierto 3.9.5 insite/package.json(previouslynpx --yes prettierfloated to latest), so the gate can't flap when a new prettier release changes formatting rules.Verification
just checkon this branch: 7/7 gates pass (format, shellcheck, clippy, test, doc, examples, site); workflow YAML parses;quality_gates.sh format shellcheckpasses with the pinned prettier.