Skip to content

Adds support for Firefox by computing Event.offsetX/Y when they are not supported natively. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colinbdclark wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds support for Firefox by computing Event.offsetX/Y when they are not supported natively. #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions js/finger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,14 @@ FingerJS.prototype.fingerPadInit = function() {
$el.append(posShower);

$el.on('mousedown', function(ev) {
FingerJS.normalizeEventOffset(ev);
fjsObj.fingerPadStartSound($el, ev.offsetX, ev.offsetY);
});
$el.on('mouseup', function(ev) {
fjsObj.fingerPadStopSound($el);
});
$el.on('mousemove', function(ev) {
FingerJS.normalizeEventOffset(ev);
fjsObj.fingerPadMoveCursor($el, ev.offsetX, ev.offsetY);
});
});
Expand Down Expand Up @@ -110,3 +112,16 @@ FingerJS.prototype.fingerPadMoveCursor = function($el, x, y) {
$el.data('synth').input(fjsObj.fingerPadGetSynthModId('carrier',$el) + ".freq", playFreqPlay);
$el.data('synth').input(fjsObj.fingerPadGetSynthModId('mod', $el) + ".freq", modFreqPlay);
}

/**
* Normalizes the event offsetX/offsetY properties across browsers, particularly for Firefox, which doesn't natively support them.
*/
FingerJS.normalizeEventOffset = function(ev) {
if (ev.offsetX === undefined) {
var offset = $(ev.target).offset();
ev.offsetX = ev.clientX - offset.left;
ev.offsetY = ev.clientY - offset.top;
}
return ev;
};