Add Monitoring of DHW System Function (MDSF) use case#246
Open
andig wants to merge 6 commits into
Open
Conversation
Groundwork for the HVAC system function and temperature use cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The Hvac and Setpoint write helpers issued a write command without checking whether the remote server feature advertises the Write() operation for the corresponding function. Guard each write helper so it returns api.ErrNotSupported unless the remote advertises Write(), matching the existing LoadControl/DeviceConfiguration behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The Hvac and Setpoint write helpers sent a list containing only the modified entry. Servers that interpret the payload as a full replacement would then drop unrelated system functions, overruns or setpoints. Send a proper partial write when the remote advertises WritePartial(). Otherwise copy the cached list, merge the modified entries and write the complete list, matching the LoadControl/DeviceConfiguration behaviour. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the Monitoring of DHW System Function (MDSF) use case (EEBus UC TS V1.0.0) as a Monitoring Appliance client actor in
usecases/ma/mdsf.Scenarios:
OperationModes,CurrentOperationModeIsOverrunActive(fromhvacSystemFunctionListData),OverrunStatus(one-time DHW overrun resolved viahvacOverrunDescriptionListDataoverrunType=oneTimeDhw+affectedSystemFunctionId)Server is a
DHWCircuitentity; all six HVAC functions are read-only in this use case. The client subscribes to theHVACserver feature (no binding). Writing the operation mode / overrun belongs to the CDSF use case.Stacked on #239 (Hvac and Setpoint client features) — only the last commit is specific to this PR.
🤖 Generated with Claude Code